lkml.org 
[lkml]   [2006]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 02/07] cpuset use combined atomic_inc_return calls
Date
On Thursday 09 February 2006 19:54, you wrote:
> @@ -1770,8 +1769,7 @@ static long cpuset_create(struct cpuset
> atomic_set(&cs->count, 0);
> INIT_LIST_HEAD(&cs->sibling);
> INIT_LIST_HEAD(&cs->children);
> - atomic_inc(&cpuset_mems_generation);
> - cs->mems_generation = atomic_read(&cpuset_mems_generation);
> + cs->mems_generation = atomic_inc_return(&cpuset_mems_generation);
> fmeter_init(&cs->fmeter);
>
> cs->parent = parent;
> @@ -1861,7 +1859,7 @@ int __init cpuset_init_early(void)
> struct task_struct *tsk = current;
>
> tsk->cpuset = &top_cpuset;
> - tsk->cpuset->mems_generation = atomic_read(&cpuset_mems_generation);
> + tsk->cpuset->mems_generation = atomic_inc_return(&cpuset_mems_generation);
> return 0;
> }

Is this hunk really correct? I did not look into the code, but from
the patch context it seems like it adds an inc here.

--
Greetings Michael.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2006-02-09 20:26    [W:0.072 / U:0.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site