Messages in this thread | | | Subject | Re: [PATCH] inotify: fix one-shot support | From | Robert Love <> | Date | Wed, 08 Feb 2006 11:16:33 -0500 |
| |
On Wed, 2006-02-08 at 08:52 +0100, Ingo Oeser wrote:
> See, now you can just pass IN_ONESHOT behavior flag without any > events to shoot at, which you couldn't do before. But this makes only > sense, if we would like to set a multi-shot mask to one-shot now.
Ack!
> Does this transition (multi shot to single shot)makes sense at all? > Is it race-free to allow this?.
It should be okay. This was my intention in the patch.
> So my suggested fix instead of yours would be: > > /* don't let user-space set invalid bits: we don't want flags set */ > mask &= IN_ALL_EVENTS | IN_ONESHOT; > if (unlikely((mask & IN_ALL_EVENTS) == 0 && !mask_add)) { > ret = -EINVAL; > goto out; > } > > Would you like a patch on top of the one submitted by you?
Yes, because my patch was already merged by Linus.
Robert Love
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |