lkml.org 
[lkml]   [2006]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [v4l-dvb-maintainer] [PATCH 07/16] Fixed i2c return value, conversion mdelay to msleep
From
Date
Hi,

On Tue, 2006-02-07 at 13:33 -0200, mchehab@infradead.org wrote:
> @@ -165,6 +168,9 @@ int em28xx_read_reg_req(struct em28xx *d
> u8 val;
> int ret;
>
> + if (dev->state & DEV_DISCONNECTED)
> + return(-ENODEV);

This looks like return was a function and is very uncommon for kernel
coding style.

> +
> em28xx_regdbg("req=%02x, reg=%02x:", req, reg);
>
> ret = usb_control_msg(dev->udev, usb_rcvctrlpipe(dev->udev, 0), req,
> @@ -195,7 +201,12 @@ int em28xx_write_regs_req(struct em28xx
> int ret;
>
> /*usb_control_msg seems to expect a kmalloced buffer */
> - unsigned char *bufs = kmalloc(len, GFP_KERNEL);
> + unsigned char *bufs;
> +
> + if (dev->state & DEV_DISCONNECTED)
> + return(-ENODEV);

Same as obove.

> +
> + bufs = kmalloc(len, GFP_KERNEL);

I think you should add this:

if (bufs == NULL)
return -ENOMEM;

Best regards,
Andreas

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-02-07 21:51    [from the cache]
©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site