Messages in this thread | | | Date | Sun, 5 Feb 2006 02:46:09 +0100 | From | Adrian Bunk <> | Subject | Re: One more unlock missing in error case |
| |
On Sat, Feb 04, 2006 at 04:08:30PM -0800, Andrew Morton wrote: > Ulrich Drepper <drepper@redhat.com> wrote: > > > > This patch is needed to in addition to the other unlocking fix which is > > already applied. It should be obvious that the system will deadlock in > > case this isn't done. > > hmm. How's about we undo that goto tangle while we're there? >...
The fput_unlock_fail label change looks good, but IMHO moving of retval settings out of the if's makes the code less readable.
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |