Messages in this thread Patch in this message | | | Date | Fri, 3 Feb 2006 21:22:20 +0100 | From | Adrian Bunk <> | Subject | [RFC: 2.6 patch] drivers/acpi/utilities/utmisc.c: remove 4 unused global functions |
| |
This patch removes the following four unused global functions from drivers/acpi/utilities/utmisc.c: - acpi_ut_strupr() - acpi_ut_generate_checksum() - acpi_ut_report_warning() - acpi_ut_report_info()
Is this patch OK or is future usage planned or are they still used on other operating systems?
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/acpi/utilities/utmisc.c | 69 -------------------------------- include/acpi/acutils.h | 8 --- 2 files changed, 77 deletions(-)
--- linux-2.6.16-rc1-mm5-full/include/acpi/acutils.h.old 2006-02-03 19:28:37.000000000 +0100 +++ linux-2.6.16-rc1-mm5-full/include/acpi/acutils.h 2006-02-03 19:29:42.000000000 +0100 @@ -279,10 +279,6 @@ void acpi_ut_report_error(char *module_name, u32 line_number); -void acpi_ut_report_info(char *module_name, u32 line_number); - -void acpi_ut_report_warning(char *module_name, u32 line_number); - /* Error and message reporting interfaces */ void ACPI_INTERNAL_VAR_XFACE @@ -454,8 +450,6 @@ void *target_object, acpi_pkg_callback walk_callback, void *context); -void acpi_ut_strupr(char *src_string); - void acpi_ut_print_string(char *string, u8 max_length); u8 acpi_ut_valid_acpi_name(u32 name); @@ -483,8 +477,6 @@ acpi_ut_get_resource_end_tag(union acpi_operand_object *obj_desc, u8 ** end_tag); -u8 acpi_ut_generate_checksum(u8 * buffer, u32 length); - u32 acpi_ut_dword_byte_swap(u32 value); void acpi_ut_set_integer_width(u8 revision); --- linux-2.6.16-rc1-mm5-full/drivers/acpi/utilities/utmisc.c.old 2006-02-03 19:28:53.000000000 +0100 +++ linux-2.6.16-rc1-mm5-full/drivers/acpi/utilities/utmisc.c 2006-02-03 19:30:04.000000000 +0100 @@ -217,39 +217,6 @@ /******************************************************************************* * - * FUNCTION: acpi_ut_strupr (strupr) - * - * PARAMETERS: src_string - The source string to convert - * - * RETURN: None - * - * DESCRIPTION: Convert string to uppercase - * - * NOTE: This is not a POSIX function, so it appears here, not in utclib.c - * - ******************************************************************************/ - -void acpi_ut_strupr(char *src_string) -{ - char *string; - - ACPI_FUNCTION_ENTRY(); - - if (!src_string) { - return; - } - - /* Walk entire string, uppercasing the letters */ - - for (string = src_string; *string; string++) { - *string = (char)ACPI_TOUPPER(*string); - } - - return; -} - -/******************************************************************************* - * * FUNCTION: acpi_ut_print_string * * PARAMETERS: String - Null terminated ASCII string @@ -814,31 +781,6 @@ /******************************************************************************* * - * FUNCTION: acpi_ut_generate_checksum - * - * PARAMETERS: Buffer - Buffer to be scanned - * Length - number of bytes to examine - * - * RETURN: The generated checksum - * - * DESCRIPTION: Generate a checksum on a raw buffer - * - ******************************************************************************/ - -u8 acpi_ut_generate_checksum(u8 * buffer, u32 length) -{ - u32 i; - signed char sum = 0; - - for (i = 0; i < length; i++) { - sum = (signed char)(sum + buffer[i]); - } - - return ((u8) (0 - sum)); -} - -/******************************************************************************* - * * FUNCTION: acpi_ut_error, acpi_ut_warning, acpi_ut_info * * PARAMETERS: module_name - Caller's module name (for error output) @@ -922,14 +864,3 @@ acpi_os_printf("ACPI Error (%s-%04d): ", module_name, line_number); } -void acpi_ut_report_warning(char *module_name, u32 line_number) -{ - - acpi_os_printf("ACPI Warning (%s-%04d): ", module_name, line_number); -} - -void acpi_ut_report_info(char *module_name, u32 line_number) -{ - - acpi_os_printf("ACPI (%s-%04d): ", module_name, line_number); -} - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |