Messages in this thread | | | Date | Tue, 28 Feb 2006 12:57:15 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 10/13] ATA ACPI: do taskfile before mode commands |
| |
On St 22-02-06 14:01:40, Randy Dunlap wrote: > From: Randy Dunlap <randy_d_dunlap@linux.intel.com> > > Do drive/taskfile-specific commands before setting the drive mode. > This allows the taskfile to unlock the drive before trying to > set the drive mode. > > Signed-off-by: Randy Dunlap <randy_d_dunlap@linux.intel.com> > --- > drivers/scsi/libata-core.c | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > --- linux-2616-rc4-ata.orig/drivers/scsi/libata-core.c > +++ linux-2616-rc4-ata/drivers/scsi/libata-core.c > @@ -4297,13 +4297,17 @@ static int ata_start_drive(struct ata_po > */ > int ata_device_resume(struct ata_port *ap, struct ata_device *dev) > { > + printk(KERN_DEBUG "ata%d: resume device\n", ap->id);
Yep, one more helpful printk. Not. Actually this is four more of them in this patch alone. Please remove your debugging code prior to merge.
Pavel
-- Web maintainer for suspend.sf.net (www.sf.net/projects/suspend) wanted... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |