lkml.org 
[lkml]   [2006]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/13] ATA ACPI: debugging infrastructure
Andrew Morton wrote:
> Jeff Garzik <jgarzik@pobox.com> wrote:
>
>>Andrew Morton wrote:
>>
>>>Jeff Garzik <jgarzik@pobox.com> wrote:
>>>
>>>
>>>>Fine-grained
>>>>message selection allows one to turn on only the messages needed, and
>>>>only for the controller desired.
>>>
>>>
>>>Except
>>>
>>>- There's (presently) no way of making all the messages go away for a
>>> non-debug build.
>>
>>They aren't supposed to go away.
>>
>
>
> It is legitimate to elect to waste memory on every machine so as to make
> the system more easily debugged by remote maintainers. But that's an
> unusual choice in the kernel context.

Not unusual, as I said, its done in a ton of net drivers.

That said, I suppose its OK to do

#define ata_msg_foo() 0

for wacky embedded situations. But the default will be enabled for all
users, not just debug kernels.


>>>- The new debug stuff isn't documented. One has funble around in the
>>> source to work out how to even turn it on. Can it be altered at runtime?
>>> Dunno - the changelogs are risible. What effect do the various flags
>>> have?
>>
>>The model has always been documented:
>>http://www.scyld.com/pipermail/vortex/2001-November/001426.html
>>(scroll down a tad)
>
>
> That's useless.

Not useless at all: It documents the model that is being implemented
quite well. libata will use the same method of bitmasks, same method of
increasing verbosity as set by debug level, same method of masking the
more verbose messages by default, but always compiling the messages into
the driver. Its highly similar.

Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-02-28 20:30    [W:0.032 / U:22.840 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site