lkml.org 
[lkml]   [2006]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/7] isdn4linux: Siemens Gigaset drivers - common module
From
Date
On Mon, 2006-02-27 at 07:23 +0100, Hansjoerg Lipp wrote:
> +#define IFNULL(a) \
> + if (unlikely(!(a)))

please please get rid of this!

first of all, gcc ALREADY treats null pointer checks as unlikely,
second of all this makes code entirely unreadable, so please just
use "if (!a)" where you would want to use IFNULL

(same goes for the variants of this just below this)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-02-27 08:55    [W:0.040 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site