Messages in this thread | | | Date | Mon, 27 Feb 2006 16:48:12 -0800 | From | Andrew Morton <> | Subject | Re: [patch] inotify: lock avoidance with parent watch status in dentry |
| |
Nick Piggin <nickpiggin@yahoo.com.au> wrote: > > Previous inotify work avoidance is good when inotify is completely > unused, but it breaks down if even a single watch is in place anywhere > in the system. Robin Holt notices that udev is one such culprit - it > slows down a 512-thread application on a 512 CPU system from 6 seconds > to 22 minutes.
A problem is that the audit tree (believe it or not) adds a pile of new inotify functionality. I don't know what those changes do and they might conflict with the changes you've made (apart from giving us two copies of inotify_inode_watched()) and the audit changes were apparently only socialised on the linux-audit mailing list and my twice-sent patch to make the audit tree compile has been ignored for a couple of weeks.
So I'm going to bitbucket the audit tree until a) it compiles and b) its inotify changes have been explained and reviewed and c) we've reviewed those changes against your optimisations. I think fixes will be needed.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |