Messages in this thread | | | Date | Mon, 27 Feb 2006 14:42:44 -0700 | From | Grant Grundler <> | Subject | Re: [PATCH 0/4] PCI legacy I/O port free driver (take 3) |
| |
On Mon, Feb 27, 2006 at 12:43:09PM -0500, Jeff Garzik wrote: > This series still leaves a lot to be desired, and creates unnecessary > driver churn.
This is a pretty small change and is not necessary for every driver. What do you still desire that this patch set doesn't provide?
> The better solution is: > > 1) pci_enable_device() enables what it can > > 2) Drivers, as they already do, will fail if they cannot map the desired > memory or IO resources that are needed. > > Thus, the PCI layer needs only to do #1, and existing driver code > handles the rest of the situation as one currently expects.
If in #1 pci_enable_device() assigns I/O Port resources even though the driver doesn't need it, PCI devices which _only_ support I/O Port space will get screwed (depending on config). We are trying to avoid that. Or do you have another way of avoiding unused resource allocation?
thanks, grant - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |