lkml.org 
[lkml]   [2006]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC/RFT][PATCH -mm] swsusp: improve memory shrinking
    On Po 27-02-06 00:32:24, Rafael J. Wysocki wrote:
    > Hi,
    >
    > On Sunday 26 February 2006 19:53, Pavel Machek wrote:
    > > > > > > I did try shrink_all_memory() five times, with .5 second delay between
    > > > > > > them, and it freed more memory at later tries.
    > > > > >
    > > > > > I wonder if the delays are essential or if so, whether they may be shorter
    > > > > > than .5 sec.
    > > > >
    > > > > I was using this with some success... (Warning, against old
    > > > > kernel). But, as I said, I consider it ugly, and it would be better to
    > > > > fix shrink_all_memory.
    > > >
    > > > Appended is a patch against the current -mm.
    > > > [It also makes
    > > > swsusp_shrink_memory() behave as documented for image_size = 0.
    > > > Currently, if it states there's enough free RAM to suspend, it won't bother
    > > > to free a single page.]
    > >
    > > Could we get bugfix part separately?
    >
    > Sure. Appended is the bugfix (I haven't tested it separately yet, but I think
    > it's simple enough) ...

    Are you sure? The way I read old code ... it looks correct to me.

    size is always > 1000 or so. if image_size = 0, size >
    image_size/PAGE_SIZE and we'll loop as long as shrink_all_memory()
    frees something.

    Pavel

    printk("Shrinking memory... ");
    do {
    /* size = How much memory would we need if we did not
    free anything? */
    size = 2 * count_highmem_pages();
    size += size / 50 + count_data_pages();
    size += (size + PBES_PER_PAGE - 1) / PBES_PER_PAGE +
    PAGES_FOR_IO;

    /* tmp = How much memory do we *need* to free in order
    to fit? */
    tmp = size;
    for_each_zone (zone)
    if (!is_highmem(zone))
    tmp -= zone->free_pages;
    if (tmp > 0) {
    tmp = shrink_all_memory(SHRINK_BITE);
    if (!tmp)
    return -ENOMEM;
    pages += tmp;
    } else if (size > image_size / PAGE_SIZE) {
    tmp = shrink_all_memory(SHRINK_BITE);
    pages += tmp;
    }
    printk("\b%c", p[i++%4]);



    --
    Web maintainer for suspend.sf.net (www.sf.net/projects/suspend) wanted...
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-02-27 00:55    [W:4.269 / U:0.544 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site