Messages in this thread |  | | | Date | Sat, 25 Feb 2006 14:10:25 +0100 | | From | Adrian Bunk <> | | Subject | Re: 2.6.16-rc4-mm2: drivers/rtc/utils.c should become part of a generic implementation |
| |
On Sat, Feb 25, 2006 at 05:46:19AM +0100, Alessandro Zummo wrote: > On Sat, 25 Feb 2006 04:31:18 +0100 > Adrian Bunk <bunk@stusta.de> wrote: > > > Always building drivers/rtc/utils.o even if no RTC support is enabled > > seems to be a workaround for an issue that should instead be fixed > > properly: > > > > The code in e.g. fs/udf/udftime.c or drivers/scsi/ips.c has some > > overlaps with what you are adding (they are not doing exactly the > > same, but there are overlaps). > > > > We should have one common set of defines/inlines/functions dealing with > > all these time conversion, leap year, length of months/years etc. issues > > instead of adding one more implementation in this area. > > I agree. My idea was to place those routines in utils.o and then > modify callers, like udftime.c and ips.c to use them. What is currently > in utils.c has been gathered from files that were known to me, > lice rtctime.c in the arm arch and some rtc drivers. Once deployed, > it will be easier to find and convert similar routines.y
Sounds good, but for generic functions, two adjustments are required: - move the code to lib/ - remove rtc_ prefixes from the functions
> Best regards, > Alessandro Zummo,
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |