Messages in this thread | | | Date | Fri, 24 Feb 2006 06:16:56 -0500 | From | Alan Cox <> | Subject | Re: + add-cpia2-camera-support.patch added to -mm tree |
| |
On Fri, Feb 24, 2006 at 10:06:55AM +0100, Arjan van de Ven wrote: > you are adding rvmalloc copy number 14; seems you own the task to make > it generic now ;) > Also I thought SetPageReserved and friends are deprecated :)
Heading that way, which is fine by me.
> > +struct camera_data { > > + /* locks */ > > + struct semaphore busy_lock; /* guard against SMP multithreading */ > > + struct v4l2_prio_state prio; > > + > > please make this use mutexes; adding new semaphores for no reason is not > a good idea...
Good idea. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |