lkml.org 
[lkml]   [2006]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subject2.6.16-rc4-mm2: drivers/rtc/utils.c should become part of a generic implementation
On Fri, Feb 24, 2006 at 03:10:02AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.16-rc4-mm1:
>...
> +rtc-subsystem-class.patch
>...
> rtc subsystem rework. These patches are being updated.
>...

Always building drivers/rtc/utils.o even if no RTC support is enabled
seems to be a workaround for an issue that should instead be fixed
properly:

The code in e.g. fs/udf/udftime.c or drivers/scsi/ips.c has some
overlaps with what you are adding (they are not doing exactly the
same, but there are overlaps).

We should have one common set of defines/inlines/functions dealing with
all these time conversion, leap year, length of months/years etc. issues
instead of adding one more implementation in this area.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-02-25 04:34    [from the cache]
©2003-2011 Jasper Spaans