Messages in this thread | | | Date | Fri, 24 Feb 2006 19:09:38 +0000 | From | Christoph Hellwig <> | Subject | Re: [Patch 2/3] fast VMA recycling |
| |
On Fri, Feb 24, 2006 at 08:05:16PM +0100, Andi Kleen wrote: > I think voluntary preempt is generally a good idea, but we should make it optional > for down() since it can apparently cause bad side effects (like holding > semaphores/mutexes for too long) > > There would be two possible ways: > > have default mutex_lock()/down() do a might_sleep() > with preemption and have a separate variant that doesn't preempt > or have the default non preempt and a separate variant > that does preempt.
better remove the stupid cond_resched() from might_sleep which from it's naming already is a debug thing and add it to those places where it makes sense.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |