Messages in this thread | | | Date | Fri, 24 Feb 2006 19:09:26 +0100 (MET) | From | Jan Engelhardt <> | Subject | Re: Kernel 'vga=' parameter wierdness |
| |
>> > You're right. I thought '0164' was octal - 0 prefix. >> > >> Quite misleading. This should be fixed. > >What fix do you propose? > That /^0[xX][0-9a-fA-F]+$/ is required to interpret $_ as a hexadecimal number, that /^0[0-7]+$/ is required to interpret it as an octal, and everything else for a normal decimal number. IOW, using strtol(my_vga_string, NULL, 0) everywhere (GRUB, as well as the "vga selector" in the kernel). And making sure the vga selector (i.e. when booting with vga=ask) always prefix numbers with 0x when they are supposed to be in hexadecimal, i.e. e.g. for(i=0; ...) printf("%#x %dx%d\n", i, vga_modes[i].width, vga_modes[i].height); instead of currently printf("%x %dx%d\n", ...)
Jan Engelhardt -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |