Messages in this thread | | | Date | Fri, 24 Feb 2006 10:04:52 -0800 | From | Greg KH <> | Subject | Re: Missing piece from as659 |
| |
On Fri, Feb 24, 2006 at 12:53:01PM -0500, Alan Stern wrote: > On Fri, 24 Feb 2006, Matthew Wilcox wrote: > > http://www.ussg.iu.edu/hypermail/linux/kernel/0602.2/2673.html > > If it is a bug, of course. It's not clear to me whether it's permissible > > to call pci_dev_put under a spinlock or not. That boils down to whether > > kobject ->release methods can sleep or not. That isn't documented in > > Documentation/kobject.txt and I rather think it should be. > > It is a bug, but it has been ignored up until recently. Within the last > month or two, Greg added a might_sleep() call to put_device(). It > wouldn't hurt to do the same thing to kobject_put(), or maybe just > kobject_release().
kobject_put() will not necessarily sleep, it's only the device_put that will, due to the locking in the driver core.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |