Messages in this thread | | | Date | Fri, 24 Feb 2006 02:09:21 -0500 (EST) | From | Steven Rostedt <> | Subject | Re: 2.6.15-rt17 |
| |
On Fri, 24 Feb 2006, Ingo Molnar wrote:
> > * Steven Rostedt <rostedt@goodmis.org> wrote: > > > + printk("| This is not a BUG\n"); > > + printk("| turn off CONFIG_DEBUG_STACK_OVERFLOW if you don't want this\n"); > > i added the patch below - we want to know about too high stack > footprints.
Yeah you're right, those should be reported.
> > MAX_STACK-worst_stack_left, (long)MAX_STACK); > + fill_ratio = (MAX_STACK-worst_stack_left)*100/(long)MAX_STACK; > + printk("| Stack fill ratio: %02ld%%", fill_ratio); > + if (fill_ratio >= 90) > + printk(" - BUG: that's quite high, please report this!\n"); > + else > + printk(" - that's still OK, no need to report this.\n"); > printk("------------|\n");
On the non bug case, I would still state the way to turn it off. It becomes quite annoying if there are no bugs, and a non kernel hacker may not know how to disable it.
-- Steve
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |