Messages in this thread | | | Date | Fri, 24 Feb 2006 08:19:15 -0800 (PST) | From | Christoph Lameter <> | Subject | Re: slab: Remove SLAB_NO_REAP option |
| |
On Fri, 24 Feb 2006, Pekka Enberg wrote:
> > One cache_reap() may scan the free list but once its free the code is > > skipped. > > Which is _totally_ redundant for cache_cache.
Correct. So you are going to add a check to the loop that is useless for all other caches? The many have to sacrfice for the one?
> I don't think its worth it. It doesn't make much sense to create a > separate object cache if you're not using it, we're better off > converting those to kmalloc(). cache_cache is there to make > bootstrapping easier, it is very unlikely that you ever have more than > one page allocated for that cache which is why scanning the freelist > _at all_ is silly. I think SLAB_NO_REAP should go away but we also > must ensure we don't introduce a performance regression while doing > that.
Got some way to get rid of cache_cache? Or remove it after boot?
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |