Messages in this thread | | | Date | Thu, 23 Feb 2006 11:32:04 -0500 | From | Benjamin LaHaise <> | Subject | Re: [PATCH] change b_size to size_t |
| |
On Thu, Feb 23, 2006 at 08:28:12AM -0800, Badari Pulavarty wrote: > Here is the updated version of the patch, which changes > buffer_head.b_size to size_t to support mapping large > amount of disk blocks (for large IOs).
Your patch doesn't seem to be inline, so I can't quote it. Several problems: on 64 bit platforms you introduced 4 bytes of padding into buffer_head. atomic_t only takes up 4 byte, while size_t is 8 byte aligned. This is a waste of memory, imo, seeing as the vast majority of systems out there will not be doing 4GB+ ios any time soon.
Also, the cast to unsigned long long for size_t is pretty atrocious. Cast to unsigned long if anything, as size_t is unsigned long on all platforms linux runs on.
-ben -- "Ladies and gentlemen, I'm sorry to interrupt, but the police are here and they've asked us to stop the party." Don't Email: <dont@kvack.org>. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |