lkml.org 
[lkml]   [2006]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 04/23] proc: Remove unnecessary and misleading assignments from proc_pid_make_inode.
    From
    Date

    The removed fields are already set by proc_alloc_inode.
    Initializing them in proc_pid_make_inode implies they need
    to be set. At least ei->pde was not set on all paths making
    it look like proc_pid_make_inode was buggy. So just remove
    the redundant assignments.

    Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>


    ---

    fs/proc/base.c | 2 --
    1 files changed, 0 insertions(+), 2 deletions(-)

    2b0fa5317e60458090cfa528e9421ecd3de38f6b
    diff --git a/fs/proc/base.c b/fs/proc/base.c
    index 24a3526..56ca519 100644
    --- a/fs/proc/base.c
    +++ b/fs/proc/base.c
    @@ -1310,7 +1310,6 @@ static struct inode *proc_pid_make_inode

    /* Common stuff */
    ei = PROC_I(inode);
    - ei->task = NULL;
    inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME;
    inode->i_ino = fake_ino(task->pid, ino);

    @@ -1335,7 +1334,6 @@ out:
    return inode;

    out_unlock:
    - ei->pde = NULL;
    iput(inode);
    return NULL;
    }
    --
    1.2.2.g709a
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-02-23 17:02    [W:0.038 / U:32.152 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site