Messages in this thread | | | Date | Mon, 20 Feb 2006 10:26:39 +0000 | From | Matthew Garrett <> | Subject | Re: [PATCH 2.6.15.3 1/1] ACPI: Atlas ACPI driver |
| |
On Mon, Feb 20, 2006 at 10:13:53AM +0800, jayakumar.acpi@gmail.com wrote:
> + /* setup proc entry to set and get lcd brightness */ > + proc = create_proc_read_entry("lcd", S_IFREG | S_IRUGO | S_IWUSR, > + atlas_proc_dir, atlas_read_proc_lcd, atlas_dev);
For basic sanity, could this please be a standard backlight driver rather than sticking yet another backlight control under yet another directory in /proc? It makes userspace much, much easier. drivers/video/backlight/corgi_bl.c is an example, but also see my posts to acpi-devel with patches that add it to existing acpi drivers.
> + return atlas_acpi_button_add(device);
What buttons does the hardware have? Would it make more sense for it to be an input driver rather than (or as well as) just dropping stuff in acpi/events?
-- Matthew Garrett | mjg59@srcf.ucam.org - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |