Messages in this thread Patch in this message | | | Date | Mon, 20 Feb 2006 09:14:38 +0100 | From | Adam Tla/lka <> | Subject | Re: [PATCH]console:UTF-8 mode compatibility fixes - new version #1 |
| |
Hope the last version applaying to current console design. What do you think?
Description:
Fixed UTF-8 mode so alternate charset modes always work according to control sequences interpreted in do_con_trol function: smacs = '\x0e', rmacs = '\x0f' if vt100 translation map for alternate charset is active which means enacs = '\e)0' preserving backward US-ASCII and VT100 semigraphics compatibility.
Malformed UTF sequences are represented as sequences of replacement glyphs, original codes or '?' as a last resort if replacement glyph is undefined and UCS-2 code does not fit in 0-127 code range.
Signed-off-by: Adam Tla/lka <atlka@pg.gda.pl>
--- drivers/char/vt_orig.c 2006-02-13 11:33:54.000000000 +0100 +++ drivers/char/vt.c 2006-02-20 08:53:59.000000000 +0100 @@ -63,6 +63,16 @@ * * Removed console_lock, enabled interrupts across all console operations * 13 March 2001, Andrew Morton + * + * Fixed UTF-8 mode so alternate charset modes always work according + * to control sequences interpreted in do_con_trol function: + * smacs = '\x0e', rmacs = '\x0f' if vt100 translation map for alternate + * charset is active which means enacs = '\e)0' + * preserving backward US-ASCII and VT100 semigraphics compatibility, + * malformed UTF sequences represented as sequences of replacement glyphs, + * original codes or '?' as a last resort if replacement glyph is undefined + * and UCS-2 code does not fit in 0-127 code range + * by Adam Tla/lka <atlka@pg.gda.pl>, Feb 2006 */ #include <linux/module.h> @@ -1991,17 +2001,23 @@ static int do_con_write(struct tty_struc /* Do no translation at all in control states */ if (vc->vc_state != ESnormal) { tc = c; - } else if (vc->vc_utf) { + } else if (vc->vc_utf && !vc->vc_disp_ctrl) { /* Combine UTF-8 into Unicode */ - /* Incomplete characters silently ignored */ + /* Malformed sequence represented as replacement glyphs */ +rescan_last_byte: if(c > 0x7f) { - if (vc->vc_utf_count > 0 && (c & 0xc0) == 0x80) { - vc->vc_utf_char = (vc->vc_utf_char << 6) | (c & 0x3f); - vc->vc_utf_count--; - if (vc->vc_utf_count == 0) - tc = c = vc->vc_utf_char; - else continue; + if (vc->vc_utf_count) { + if ((c & 0xc0) == 0x80) { + vc->vc_utf_char = (vc->vc_utf_char << 6) | (c & 0x3f); + if (--vc->vc_utf_count) { + vc->vc_npar++; + continue; + } + tc = c = vc->vc_utf_char; + } else + goto insert_replacement_glyph; } else { + vc->vc_npar = 0; if ((c & 0xe0) == 0xc0) { vc->vc_utf_count = 1; vc->vc_utf_char = (c & 0x1f); @@ -2018,12 +2034,13 @@ static int do_con_write(struct tty_struc vc->vc_utf_count = 5; vc->vc_utf_char = (c & 0x01); } else - vc->vc_utf_count = 0; + goto insert_replacement_glyph; continue; } } else { + if (vc->vc_utf_count) + goto insert_replacement_glyph; tc = c; - vc->vc_utf_count = 0; } } else { /* no utf */ tc = vc->vc_translate[vc->vc_toggle_meta ? (c | 0x80) : c]; @@ -2040,31 +2057,41 @@ static int do_con_write(struct tty_struc * direct-to-font zone in UTF-8 mode. */ ok = tc && (c >= 32 || - (!vc->vc_utf && !(((vc->vc_disp_ctrl ? CTRL_ALWAYS - : CTRL_ACTION) >> c) & 1))) + !(vc->vc_disp_ctrl ? (CTRL_ALWAYS >> c) & 1 : + vc->vc_utf || ((CTRL_ACTION >> c) & 1))) && (c != 127 || vc->vc_disp_ctrl) && (c != 128+27); if (vc->vc_state == ESnormal && ok) { /* Now try to find out how to display it */ tc = conv_uni_to_pc(vc, tc); - if ( tc == -4 ) { + if ( tc & ~charmask ) { + if ( tc == -4 ) { /* If we got -4 (not found) then see if we have defined a replacement character (U+FFFD) */ - tc = conv_uni_to_pc(vc, 0xfffd); +insert_replacement_glyph: + tc = conv_uni_to_pc(vc, 0xfffd); /* One reason for the -4 can be that we just did a clear_unimap(); try at least to show something. */ - if (tc == -4) - tc = c; - } else if ( tc == -3 ) { + if (tc & ~charmask) { + if ( c & ~0x7f ) + tc = '?'; + else + tc = c; + } + } else if ( tc == -3 ) { /* Bad hash table -- hope for the best */ - tc = c; + if ( c & ~0x7f ) + tc = '?'; + else + tc = c; + } else + continue; /* Conversion failed */ } - if (tc & ~charmask) - continue; /* Conversion failed */ +repeat_replacement_glyph: if (vc->vc_need_wrap || vc->vc_decim) FLUSH if (vc->vc_need_wrap) { @@ -2088,6 +2115,15 @@ static int do_con_write(struct tty_struc vc->vc_x++; draw_to = (vc->vc_pos += 2); } + if (vc->vc_utf_count) { + if (vc->vc_npar) { + vc->vc_npar--; + goto repeat_replacement_glyph; + } + vc->vc_utf_count = 0; + c = orig; + goto rescan_last_byte; + } continue; } FLUSH - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |