Messages in this thread | | | Date | Sun, 19 Feb 2006 15:57:43 -0800 (PST) | From | Patrick Mochel <> | Subject | Re: [linux-pm] [PATCH 2/5] [pm] Add state field to pm_message_t (to hold actual state device is in) |
| |
On Sat, 18 Feb 2006, Pavel Machek wrote:
> Hi! > > > > diff --git a/include/linux/pm.h b/include/linux/pm.h > > index 5be87ba..a7324ea 100644 > > --- a/include/linux/pm.h > > +++ b/include/linux/pm.h > > @@ -140,6 +140,7 @@ struct device; > > > > typedef struct pm_message { > > int event; > > + u32 state; > > } pm_message_t; > > We have had enough problems with u32s before... What about > char *, and pass real state names?
I certainly agree that is better in an ideal implementation. But, the intent of the patches was not to fix the infrastructure; it was to fix the interface to be compatible with previous behavior (while accounting for changes made in the area that happened in the process of breaking it).
Thanks,
Pat
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |