lkml.org 
[lkml]   [2006]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 02/22] Firmware interface code for IB device.
    On Fri, Feb 17, 2006 at 04:57:07PM -0800, Roland Dreier wrote:
    > From: Roland Dreier <rolandd@cisco.com>
    >
    > This is a very large file with way too much code for a .h file.
    > The functions look too big to be inlined also. Is there any way
    > for this code to move to a .c file?
    > ---
    >
    > drivers/infiniband/hw/ehca/hcp_if.h | 2022 +++++++++++++++++++++++++++++++++++

    > +#include "ehca_tools.h"
    > +#include "hipz_structs.h"
    > +#include "ehca_classes.h"
    > +
    > +#ifndef EHCA_USE_HCALL
    > +#include "hcz_queue.h"
    > +#include "hcz_mrmw.h"
    > +#include "hcz_emmio.h"
    > +#include "sim_prom.h"
    > +#endif
    > +#include "hipz_fns.h"
    > +#include "hcp_sense.h"
    > +#include "ehca_irq.h"
    > +
    > +#ifndef CONFIG_PPC64
    > +#ifndef Z_SERIES
    > +#warning "included with wrong target, this is a p file"
    > +#endif
    > +#endif
    > +
    > +#ifdef EHCA_USE_HCALL
    > +
    > +#ifndef EHCA_USERDRIVER
    > +#include "hcp_phyp.h"
    > +#else
    > +#include "testbench/hcallbridge.h"
    > +#endif
    > +#endif

    the ifdefs should all go away and the build system should make sure it's
    only built for the right platforms.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-02-18 13:21    [W:0.023 / U:0.208 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site