Messages in this thread | | | Date | Sat, 18 Feb 2006 01:45:29 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 2/2] fix file counting |
| |
Dipankar Sarma <dipankar@in.ibm.com> wrote: > > > - if (get_nr_files() >= files_stat.max_files && > > - !capable(CAP_SYS_ADMIN)) > > - goto over; > > + if (get_nr_files() >= files_stat.max_files && !capable(CAP_SYS_ADMIN)) { > > + /* > > + * percpu_counters are inaccurate. Do an expensive check before > > + * we go and fail. > > + */ > > + if (percpu_counter_sum(&nr_files) >= files_stat.max_files) > > + goto over; > > + } > > Slight optimization - > > if (get_nr_files() >= files_stat.max_files) { > if (capable(CAP_SYS_ADMIN)) { > /* > * percpu_counters are inaccurate. Do an expensive check before > * we go and fail. > */ > if (percpu_counter_sum(&nr_files) >= > files_stat.max_files) > goto over; > } else > goto over; > }
That changes the behaviour for root. Maybe you meant !capable(), but that still changes the behaviour. I'm all confused.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |