lkml.org 
[lkml]   [2006]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] fix file counting
Dipankar Sarma <dipankar@in.ibm.com> wrote:
>
> > - if (get_nr_files() >= files_stat.max_files &&
> > - !capable(CAP_SYS_ADMIN))
> > - goto over;
> > + if (get_nr_files() >= files_stat.max_files && !capable(CAP_SYS_ADMIN)) {
> > + /*
> > + * percpu_counters are inaccurate. Do an expensive check before
> > + * we go and fail.
> > + */
> > + if (percpu_counter_sum(&nr_files) >= files_stat.max_files)
> > + goto over;
> > + }
>
> Slight optimization -
>
> if (get_nr_files() >= files_stat.max_files) {
> if (capable(CAP_SYS_ADMIN)) {
> /*
> * percpu_counters are inaccurate. Do an expensive check before
> * we go and fail.
> */
> if (percpu_counter_sum(&nr_files) >=
> files_stat.max_files)
> goto over;
> } else
> goto over;
> }

That changes the behaviour for root. Maybe you meant !capable(), but that
still changes the behaviour. I'm all confused.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-02-18 10:49    [W:0.070 / U:3.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site