Messages in this thread | | | Subject | Re: [PATCH 02/22] Firmware interface code for IB device. | From | Roland Dreier <> | Date | Fri, 17 Feb 2006 18:04:56 -0800 |
| |
Greg> Roland, your comments are fine, but what about the original Greg> author's descriptions of what each patch are?
This is actually me breaking up a giant driver into pieces small enough to post to lkml without hitting the 100 KB limit.
This is just an RFC -- I assume the driver is going to get merged in the end as one big git changeset with a changelog like "add driver for IBM eHCA InfiniBand adapters".
Greg> Come on, IBM allows developers to post code to lkml, just Greg> look at the archives for proof. For them to use a proxy Greg> like this is very strange, and also, there is no Greg> Signed-off-by: record from the original authors, which is Greg> not ok.
Well, the eHCA guys tell me that they can't post patches to lkml.
You're right that the final merge will have to have an IBM Signed-off-by: line but as I said this is just an RFC. There are many reasons beyond patch format issues that make this stuff unmergeable as-is.
Greg> And why aren't you using the standard firmware interface in Greg> the kernel?
This is actually stuff to talk to the firmware that sits below the kernel on IBM ppc64 machines, not an interface to load device firmware from userspace.
- R. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |