lkml.org 
[lkml]   [2006]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Subject[PATCH 00/22] [RFC] IBM eHCA InfiniBand adapter driver
    Date
    Here's a series of patches that add an InfiniBand adapter driver
    for IBM eHCA hardware. Please look it over with an eye towards issues
    that need to be addressed before merging this upstream.

    This patch series is somewhat unusual in that I am not the original
    author of this driver -- I am just sending it for review for the
    authors, who are apparently not able to post patches themselves due to
    internal issues at IBM. However they are cc'ed and will respond to
    comments in this thread.

    In fact I have some issues with the code myself that need to be
    addressed before this driver is mergeable. I've included most of them
    in the individual patches, although I have some general comments too.
    However I would like to get some early feedback for the ehca authors
    from the wider community. In particular I think its important to run
    this past the ppc64 experts, since I'm not sure what the standards for
    this sort of pSeries driver are.

    Anyway, my general comments:

    - The #ifs that test EHCA_USERDRIVER and __KERNEL__ should be killed.
    We know that this is kernel code, so there's no reason to include
    userspace compatibility junk.

    - Many of the comments look like they are for some automatic
    documentation system that is not quite kerneldoc. They should be
    fixed to be real kerneldoc comments.

    - In general there is a huge amount of code in large inline functions
    in .h files. Things should be reorganized to cut this down to a
    sane amount.

    Thanks,
    Roland
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-02-18 02:00    [W:4.292 / U:0.316 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site