Messages in this thread | | | Date | Fri, 17 Feb 2006 16:12:47 +0000 | From | Al Viro <> | Subject | Re: [PATCH] add __force tag to fb_readb, etc. |
| |
On Sat, Feb 18, 2006 at 12:04:08AM +0900, Atsushi Nemoto wrote: > This patch fixes many sparse warnings on MIPS (and some other) platform.
ITYM "hides". You've just lost anything resembling typechecking of arguments; it might be wrong in the current form, but at least we get a reminder of possible problems.
With __force you've lost _all_ warnings - anything goes. NAK. At the very least, figure out what type should the argument be and add a (non-force) cast to that before forcing it. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |