lkml.org 
[lkml]   [2006]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/9] isdn4linux: Siemens Gigaset drivers - common module
    On 11.02.2006 [15:52:27 +0100], Hansjoerg Lipp wrote:
    > From: Tilman Schmidt <tilman@imap.cc>, Hansjoerg Lipp <hjlipp@web.de>
    >
    > This patch adds the common include file for the Siemens Gigaset drivers,
    > providing definitions used by all of the Gigaset ISDN driver source files.
    > It also adds the main source file of the gigaset module which manages
    > common functions not specific to the type of connection to the device.

    <snip>

    > +#define GIG_TICK (HZ / 10)

    This should probable be in milliseconds and use msecs_to_jiffies either
    with another #define, or in the code directly (as Greg also indicated).
    That way, we avoid rounding issues as best we can with HZ==250.

    <snip>

    > +/* gigaset_initcs
    > + * Allocate and initialize cardstate structure for Gigaset driver
    > + * Calls hardware dependent gigaset_initcshw() function
    > + * Calls B channel initialization function gigaset_initbcs() for each B channel
    > + * parameters:
    > + * drv hardware driver the device belongs to
    > + * channels number of B channels supported by device
    > + * onechannel !=0: B channel data and AT commands share one communication channel
    > + * ==0: B channels have separate communication channels
    > + * ignoreframes number of frames to ignore after setting up B channel
    > + * cidmode !=0: start in CallID mode
    > + * modulename name of driver module (used for I4L registration)
    > + * return value:
    > + * pointer to cardstate structure
    > + */
    > +struct cardstate *gigaset_initcs(struct gigaset_driver *drv, int channels,
    > + int onechannel, int ignoreframes,
    > + int cidmode, const char *modulename)
    > +{

    <snip>

    > + cs->timer.data = (unsigned long) cs;
    > + cs->timer.function = timer_tick;
    > + cs->timer.expires = jiffies + GIG_TICK;

    setup_timer()?

    Thanks,
    Nish
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-02-15 05:15    [W:0.024 / U:33.832 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site