lkml.org 
[lkml]   [2006]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] [CM4000,CM4040] Add device class bits to enable udev device creation
On Tue, Jan 31, 2006 at 06:09:27PM -0800, Andrew Morton wrote:
> Harald Welte <laforge@gnumonks.org> wrote:
> >
> > Please apply this fix to the cm4000/4040 drivers, thanks!
> >
> > [CM4000,CM4040] Add device class bits to enable udev device creation
> >
> > Using this patch, Omnikey CardMan 4000 and 4040 devices automatically
> > get their device nodes created by udev.
>
> Dominik has made quite widespread changes to these drivers - enough that
> I'm not confident to fix the rejects, make it compile and hope that it
> still works.

sorry for that. I honestly don't have the time to track two trees, and
I do all my development work against Linus' main tree, therefore my
patches are against that tree, too.

> So can you please sort things out with Dominik? I guess a tested patch
> against -mm4 would be ideal.

The question is: Why wouldn't my patch directly go mainline but rather
via -mm? It is a very special-purpose device, the number of users are
small, it clearly fixes the bug that no device nodes are created, and
the fix came from the original maintainer.

> I note that these drivers forget to check for pcmcia_register_driver()
> failure. That's a fairly good way of getting an oops in rmmod.

Thanks, I'll cook up a fix.

--
- Harald Welte <laforge@gnumonks.org> http://gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2006-02-14 09:08    [W:0.078 / U:1.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site