lkml.org 
[lkml]   [2006]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] mm: Implement Swap Prefetching v24
Date
On Saturday 11 February 2006 03:47, Con Kolivas wrote:
> Try again. Tackled everything I could think of mentioned and more.

Hrm BUG..

This version appears to work fine with the pages being added to the tail of
the LRU, however there's a problem with the custom lru_cache_add_tail
function. I end up hitting a bug at:
if (!TestClearPageLRU(page))
BUG();

in isolate_lru_pages called from shrink_zone, find_busiest_group,
shrink_slab... ultimately from kswapd.

Just looking at the lru_cache_add function I note that my lru_cache_add_tail
function is missing a page_cache_get on the page before adding it to the LRU.
I'm guessing this is wrong.

Cheers,
Con

P.S. Sorry if this thread is getting long winded; there's a record amount of
noise on lkml already :(
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-02-11 02:57    [W:0.037 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site