Messages in this thread | | | Date | Sat, 9 Dec 2006 12:41:41 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [RFC] [PATCH] virtual memmap on sparsemem v3 [3/4] static virtual mem_map |
| |
On Fri, 8 Dec 2006 19:33:23 -0800 Andrew Morton <akpm@osdl.org> wrote:
> > > > > Would prefer to unconditionally include the header file - conditional inclusions > > > like this can cause compile failures when someone changes a config option. They > > > generally raise the complexity level. > > > > > Okay. > > Now, forward declearation of 'struct page' is in mmzone.h. > > I'll remove it and include mm_types.h instead of it. > > If someone says "Don't do that", I'll look for anothere way. > > > > This header needs mm_types.h, so including it is certainly OK - there's no > choice. But I think it'd be better to include mm_types.h outside of any > ifdefs. Just stick the #include at the start of the file as usual. > Okay, I'll make clean up patch in that way.
Thanks, -Kame
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |