| Date | Fri, 8 Dec 2006 00:35:00 -0500 | From | Josef Sipek <> | Subject | Re: [PATCH 35/35] Unionfs: Extended Attributes support |
| |
On Thu, Dec 07, 2006 at 12:04:43PM +0100, Jan Engelhardt wrote: > > On Dec 4 2006 07:31, Josef 'Jeff' Sipek wrote: > > If the makefile contains > > >--- a/fs/unionfs/Makefile > >+++ b/fs/unionfs/Makefile > >@@ -3,3 +3,5 @@ obj-$(CONFIG_UNION_FS) += unionfs.o > > unionfs-y := subr.o dentry.o file.o inode.o main.o super.o \ > > stale_inode.o branchman.o rdstate.o copyup.o dirhelper.o \ > > rename.o unlink.o lookup.o commonfops.o dirfops.o sioq.o > >+ > >+unionfs-$(CONFIG_UNION_FS_XATTR) += xattr.o > > then you don't need > > >--- a/fs/unionfs/copyup.c > >+++ b/fs/unionfs/copyup.c > >@@ -18,6 +18,75 @@ > > > > #include "union.h" > > > >+#ifdef CONFIG_UNION_FS_XATTR > > ^^ this, do you?.
Beware, copyup.c gets compiled all the time even when you don't have xattrs enabled.
> >+#include "union.h" > >+ > >+/* This is lifted from fs/xattr.c */ > >+void *xattr_alloc(size_t size, size_t limit) > > Same as for init_inode_cache, possibly prefix with unionfs.
Right.
Josef "Jeff" Sipek.
-- A computer without Microsoft is like chocolate cake without mustard. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|