lkml.org 
[lkml]   [2006]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: -mm merge plans for 2.6.20
Hi,

On Tue, 05 Dec 2006, Roman Zippel wrote:
> On Mon, 4 Dec 2006, Andrew Morton wrote:
> > kbuild-dont-put-temp-files-in-the-source-tree.patch
> > actually-delete-the-as-instr-ld-option-tmp-file.patch
>
> Andi had objections about the mktemp usage and I agree with him.
> The proposed patch in bugzilla didn't have this and no further
> justification was given for why it's needed.
> Below is a replacement patch with some improvements:
> - kbuild doesn't use $(AS), so use $(CC)
> - tmp dir needs only to be calculated once
> - reformat a bit to keep it under 80 columns and to be more readable
>
> bye, Roman
>
> Signed-off-by: Roman Zippel <zippel@linux-m68k.org>

This patch looks good to me, and I'd prefer it over the (twice
corrected) one currently in -mm.

- It's close to what Daniel Drake proposed recently [1] (main
difference: corrects the very same problem for ld-option, which might
otherwise bite us later) and what's already in Gentoo's patchkernel,

- it abstains from using mktemp, hopefully making Andi happy ;),

- resolves the current Gentoo sandbox issues without touching more
kbuild code than necessary.

Kind regards,
Horst

[1]Message-Id: <20061202194544.D9F057B40A0@zog.reactivated.net>

--
PGP-Key 0xD40E0E7A
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2006-12-06 04:49    [from the cache]
©2003-2011 Jasper Spaans