lkml.org 
[lkml]   [2006]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC] rfkill - Add support for input key to control wireless radio
Date
From
On Tuesday 05 December 2006 11:32, Christoph Hellwig wrote:
> > +/*
> > + * Function called by the key driver when the rfkill structure
> > + * needs to be registered.
> > + */
> > +int rfkill_register_key(struct rfkill *rfkill, int init_status)
> > +{
> > + struct rfkill_type *type = &master->type[rfkill->key_type];
> > + struct rfkill_key *key;
> > + int status;
> > +
> > + if (!rfkill)
> > + return -EINVAL;
> > +
> > + if (rfkill->key_type >= KEY_TYPE_MAX)
> > + return -EINVAL;
> > +
> > + /*
> > + * Increase module use count to prevent this
> > + * module to be unloaded while there are still
> > + * registered keys.
> > + */
> > + if (!try_module_get(THIS_MODULE))
> > + return -EBUSY;
>
> This is obviously broken. Please add a "struct module *owner;"
> field to struct rfkill instead.

Thanks, will fix this asap.

Ivo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-12-05 22:23    [W:0.211 / U:0.384 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site