Messages in this thread | | | Date | Tue, 05 Dec 2006 17:58:38 +0100 | From | Michal Schmidt <> | Subject | Re: PREEMPT is messing with everyone |
| |
Jaswinder Singh skrev: > Yes, Compiler will remove it but this looks ugly and confusing. > > Why dont we use like this :- > > #ifdef CONFIG_PREEMPT > #include <linux/preempt.h> > #endif > > #ifdef CONFIG_PREEMPT > preempt_disable(); > #endif > > #ifdef CONFIG_PREEMPT > preempt_enable(); > #endif
Surely you're joking. It is much more readable and maintainable to hide the #ifdef-hackery in header files than to clutter the *.c files.
Michal
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |