Messages in this thread | | | Subject | Re: [GFS2] Change argument of gfs2_dinode_out [17/70] | From | Steven Whitehouse <> | Date | Mon, 04 Dec 2006 10:05:08 +0000 |
| |
Hi,
On Fri, 2006-12-01 at 13:19 -0600, Russell Cattelan wrote: > On Thu, 2006-11-30 at 12:15 +0000, Steven Whitehouse wrote: > > >From 539e5d6b7ae8612c0393fe940d2da5b591318d3d Mon Sep 17 00:00:00 2001 > > From: Steven Whitehouse <swhiteho@redhat.com> > > Date: Tue, 31 Oct 2006 15:07:05 -0500 > > Subject: [PATCH] [GFS2] Change argument of gfs2_dinode_out > > > > Everywhere this was called, a struct gfs2_inode was available, > > but despite that, it was always called with a struct gfs2_dinode > > as an argument. By making this change it paves the way to start > > eliminating fields duplicated between the kernel's struct inode > > and the struct gfs2_dinode. > More pointless code churn. > > This only makes sense once the file system is working > and we have time to do this type of cleanup on against > a stable and TESTED code base. > I disagree and refer you to the comments from Al Viro and Pavel Machek on this subject,
Steve.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |