lkml.org 
[lkml]   [2006]   [Dec]   [4]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateMon, 04 Dec 2006 11:50:14 -0800
FromZach Brown <>
SubjectRe: [patch] remove redundant iov segment check
> Maybe we should create another internal generic_file_aio_read/write
> for in-core function? fs/read_write.c and fs/aio.c are not module-able
> and the check is already there.  For external module, we can do the
> check and then calls down to the internal one.

Maybe.  I'd rather see fewer moving parts here, not more.

> I hate to see iov is being walked multiple times ....

Indeed, hence the desire to walk it once and pass down a summary of the
results in an explicit struct.  The patch in this thread removes one
redundancy, but there are many.  I think I counted 6 iovec walks in some
path?  I can't remember which.  I'd rather tackle them all in one go.

- z
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-12-04 20:05    [W:0.218 / U:0.490 seconds]
©2003-2008 Jasper Spaans