lkml.org 
[lkml]   [2006]   [Dec]   [30]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateFri, 29 Dec 2006 21:15:07 -0800 (PST)
FromDAVID HORNER <>
Subject[KORG] re: [PATCH] cfq-iosched: tighten allow merge criteria - error in final return value ?
 I noticed a probable error in commit 719d34027e1a186e46a3952e8a24bf91ecc33837

> ....
> - if (cfqq != RQ_CFQQ(rq))
> - return 0;
> +
> + if (cfqq == RQ_CFQQ(rq))
> + return 1;
>
> return 1;
> }

Either the final return value should be 0 (zero) or
the if statement is redundant.

(I lack the skill to make a timely patch,hope this helps)


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-12-30 06:25    [from the cache]
©2003-2009