Messages in this thread | | | Subject | Re: [RFC] rfkill - Add support for input key to control wireless radio | From | Arjan van de Ven <> | Date | Sun, 03 Dec 2006 20:20:18 +0100 |
| |
On Sun, 2006-12-03 at 19:36 +0100, Ivo van Doorn wrote: > +static int rfkill_open(struct input_dev *dev) > +{ > + ((struct rfkill_key*)(dev->private))->open_count++; > + return 0; > +}
Hi,
this open_count thing smells fishy to me; what are the locking rules for it? What guarantees that the readers of it don't get the value changed underneath them between looking at the value and doing whatever action depends on it's value ?
Greetings, Arjan van de Ven
-- if you want to mail me at work (you don't), use arjan (at) linux.intel.com Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |