lkml.org 
[lkml]   [2006]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] remove 556 unneeded #includes of sched.h
On Thu, 28 Dec 2006, Al Viro wrote:

> Uh-huh. How much of build coverage have you got with it?

Well, as said in the patch description, I compiled alpha, arm, i386, ia64,
mips, powerpc, and x86_64 with allnoconfig, defconfig, allmodconfig, and
allyesconfig as well as a few randconfigs on x86_64. I also checked that
no new warnings were introduced by the patch.

> Note that "doesn't use symbols defined in sched.h" != "can remove
> include of sched.h", which, in turn, is not the same as "removing it
> doesn't cause problems on a couple of configs I've tried on amd64".

Sure. But from my experience (I started posting these patches almost five
years ago, inspired by a blog entry by davej) actually the only thing that
prevents removing the sched.h include (other than using symbols defined
there) is dereferencing current, which my scripts also check.

Tim
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-12-28 22:21    [from the cache]
©2003-2011 Jasper Spaans