lkml.org 
[lkml]   [2006]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [patch 2.6.20-rc1 4/6] PXA GPIO wrappers
Date
On Wednesday 27 December 2006 9:53 am, Pavel Machek wrote:
> Hi!
>
> > Arch-neutral GPIO calls for PXA.
> >
> > From: Philipp Zabel <philipp.zabel@gmail.com>
>
> Missing s-o-b?

Yes, still ...

> > +static inline int gpio_direction_input(unsigned gpio)
> > +{
> > + if (gpio > PXA_LAST_GPIO)
> > + return -EINVAL;
> > + pxa_gpio_mode(gpio | GPIO_IN);
> > +}
>
> Missing return 0?
>
> > +static inline int gpio_direction_output(unsigned gpio)
> > +{
> > + if (gpio > PXA_LAST_GPIO)
> > + return -EINVAL;
> > + pxa_gpio_mode(gpio | GPIO_OUT);
> > +}
> > +
>
> And here?

You're looking at about the oldest version of that patch.
Admittedly there were too many floating around...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-12-28 21:51    [W:0.084 / U:5.504 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site