lkml.org 
[lkml]   [2006]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 22/28] V4L/DVB (4995): Vivi: fix kthread_run() error check
    Date

    From: Akinobu Mita <akinobu.mita@gmail.com>

    The return value of kthread_run() should be checked by IS_ERR().

    Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
    ---

    drivers/media/video/vivi.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/media/video/vivi.c b/drivers/media/video/vivi.c
    index 3cead24..bacb311 100644
    --- a/drivers/media/video/vivi.c
    +++ b/drivers/media/video/vivi.c
    @@ -535,9 +535,9 @@ static int vivi_start_thread(struct vivi

    dma_q->kthread = kthread_run(vivi_thread, dma_q, "vivi");

    - if (dma_q->kthread == NULL) {
    + if (IS_ERR(dma_q->kthread)) {
    printk(KERN_ERR "vivi: kernel_thread() failed\n");
    - return -EINVAL;
    + return PTR_ERR(dma_q->kthread);
    }
    dprintk(1,"returning from %s\n",__FUNCTION__);
    return 0;
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-12-27 18:19    [W:0.035 / U:31.428 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site