lkml.org 
[lkml]   [2006]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 18/28] V4L/DVB (4990): Cpia2/cpia2_usb.c: fix error-path leak
    Date

    From: Amit Choudhary <amit2030@gmail.com>

    Free previously allocated memory (in array elements) if kmalloc() returns
    NULL in submit_urbs().

    Signed-off-by: Amit Choudhary <amit2030@gmail.com>
    Signed-off-by: Andrew Morton <akpm@osdl.org>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
    ---

    drivers/media/video/cpia2/cpia2_usb.c | 4 ++++
    1 files changed, 4 insertions(+), 0 deletions(-)

    diff --git a/drivers/media/video/cpia2/cpia2_usb.c b/drivers/media/video/cpia2/cpia2_usb.c
    index 28dc6a1..d8e9298 100644
    --- a/drivers/media/video/cpia2/cpia2_usb.c
    +++ b/drivers/media/video/cpia2/cpia2_usb.c
    @@ -640,6 +640,10 @@ static int submit_urbs(struct camera_dat
    cam->sbuf[i].data =
    kmalloc(FRAMES_PER_DESC * FRAME_SIZE_PER_DESC, GFP_KERNEL);
    if (!cam->sbuf[i].data) {
    + while (--i >= 0) {
    + kfree(cam->sbuf[i].data);
    + cam->sbuf[i].data = NULL;
    + }
    return -ENOMEM;
    }
    }
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-12-27 18:15    [W:0.024 / U:31.668 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site