Messages in this thread Patch in this message | | | Date | Fri, 22 Dec 2006 16:42:34 +0100 | From | Ard -kwaak- van Breemen <> | Subject | Re: [Bug 7505] Linux-2.6.18 fails to boot on AMD64 machine |
| |
On Fri, Dec 22, 2006 at 03:41:34PM +0100, Ard -kwaak- van Breemen wrote: > Repeating: I am very stupid, so I don't know if saving the irq state is ok or > not in down_read. The Andrew Morton patch but the rewritten for down_read makes the symptoms go away.
The problem obviously is that the ide_setup pokes the pci subsystem way too early. Parsing of the ide parameters should be delayed until the next run of parse_args I guess. --- linux-2.6.19.1/lib/rwsem-spinlock.c 2006-12-11 19:32:53.000000000 +0000 +++ linux-2.6.19/lib/rwsem-spinlock.c 2006-12-22 15:06:52.000000000 +0000 @@ -129,13 +129,14 @@ { struct rwsem_waiter waiter; struct task_struct *tsk; + unsigned long flags; - spin_lock_irq(&sem->wait_lock); + spin_lock_irqsave(&sem->wait_lock, flags); if (sem->activity >= 0 && list_empty(&sem->wait_list)) { /* granted */ sem->activity++; - spin_unlock_irq(&sem->wait_lock); + spin_unlock_irqrestore(&sem->wait_lock, flags); goto out; } @@ -150,7 +151,7 @@ list_add_tail(&waiter.list, &sem->wait_list); /* we don't need to touch the semaphore struct anymore */ - spin_unlock_irq(&sem->wait_lock); + spin_unlock_irqrestore(&sem->wait_lock, flags); /* wait to be given the lock */ for (;;) { | |