lkml.org 
[lkml]   [2006]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] rcu: rcutorture suspend fix
On Fri, Dec 22, 2006 at 01:08:13AM +0100, Ingo Molnar wrote:
> Subject: [patch] rcu: rcutorture suspend fix
> From: Ingo Molnar <mingo@elte.hu>
>
> fix suspend hang: rcutorture threads need to be nofreeze.

Looks straightforward enough -- I take it that rcutorture continues
upon resume? So I have to ask... Would it make sense to simply unload
the rcutorture module upon suspend?

But either way this is an improvement, so...

Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> ---
> kernel/rcutorture.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> Index: linux/kernel/rcutorture.c
> ===================================================================
> --- linux.orig/kernel/rcutorture.c
> +++ linux/kernel/rcutorture.c
> @@ -522,6 +522,7 @@ rcu_torture_writer(void *arg)
>
> VERBOSE_PRINTK_STRING("rcu_torture_writer task started");
> set_user_nice(current, 19);
> + current->flags |= PF_NOFREEZE;
>
> do {
> schedule_timeout_uninterruptible(1);
> @@ -561,6 +562,7 @@ rcu_torture_fakewriter(void *arg)
>
> VERBOSE_PRINTK_STRING("rcu_torture_fakewriter task started");
> set_user_nice(current, 19);
> + current->flags |= PF_NOFREEZE;
>
> do {
> schedule_timeout_uninterruptible(1 + rcu_random(&rand)%10);
> @@ -591,6 +593,7 @@ rcu_torture_reader(void *arg)
>
> VERBOSE_PRINTK_STRING("rcu_torture_reader task started");
> set_user_nice(current, 19);
> + current->flags |= PF_NOFREEZE;
>
> do {
> idx = cur_ops->readlock();
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-12-22 03:29    [W:0.027 / U:1.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site