![]() | |||||||||||||
Messages in this thread |
On Wed, 20 Dec 2006 13:12:35 -0800 David Brownell <david-b@pacbell.net> wrote: > +/* REVISIT these macros are correct, but suffer code explosion > + * for non-constant parameters. Provide out-line versions too. > + */ > +#define gpio_get_value(gpio) \ > + (GPLR(gpio) & GPIO_bit(gpio)) > + > +#define gpio_set_value(gpio,value) \ > + ((value) ? (GPSR(gpio) = GPIO_bit(gpio)):(GPCR(gpio) = GPIO_bit(gpio))) Why not implement them as inline functions? Or non-inline functions, come to that. Either way, programming in C is preferable to this ;) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2006-12-21 06:15 [from the cache] ©2003-2008 | |||||||||||||