lkml.org 
[lkml]   [2006]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Changes to sysfs PM layer break userspace
    On Wed, 20 Dec 2006 20:56:27 -0800
    David Brownell <david-b@pacbell.net> wrote:

    > On Wednesday 20 December 2006 7:51 pm, Andrew Morton wrote:
    >
    > > > + if (!warned) {
    > > > + printk(KERN_WARNING
    > > > + "*** WARNING *** sysfs devices/.../power/state files "
    > > > + "are only for testing, and will be removed\n");
    > > > + warned = error;
    > > > + }
    > > > +
    > > > /* disallow incomplete suspend sequences */
    > > > if (dev->bus && (dev->bus->suspend_late || dev->bus->resume_early))
    > > > return error;
    > >
    > > Well that's not much use. It tells people "hey, we broke it". They
    > > already knew that.
    >
    > No, it only does what you asked for: warning people that they're using
    > something that's going away. It says nothing about "broke".
    >

    But it's still broken, is it not?

    >
    > > What we should do is to revert 047bda36150d11422b2c7bacca1df324c909c0b3 and
    >
    > Bad answer

    Is better than breaking stuff.

    > ... see my original reply in this thread. If "the answer" is
    > to involve making PCI devices work again, better solutions include reverting
    > the patch I mentioned (adding the suspend_late/resume_early support to PCI)
    > or a version of what Matthew has produced (poking through bus layers so
    > that test can be made to fail when the bus supports those methods but the
    > specific device's driver doesn't use them).
    >

    We appear to have a choice of three options. But I see no fix in Greg's
    tree. Please let's not just accidentally forget to do this.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-12-21 06:05    [W:2.520 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site