Messages in this thread | | | Date | Wed, 20 Dec 2006 13:10:52 -0500 | From | Kristian Høgsberg <> | Subject | Re: [PATCH 3/4] Add driver for OHCI firewire host controllers. |
| |
Robert Hancock wrote: > Kristian Høgsberg wrote: ... >> +static struct pci_driver fw_ohci_pci_driver = { >> + .name = ohci_driver_name, >> + .id_table = pci_table, >> + .probe = pci_probe, >> + .remove = pci_remove, >> +}; > > How about suspend/resume support? Lots of laptops have OHCI 1394 and > full suspend/resume support is something that the current ohci1394 > driver lacks.
Yes, good point, that needs to work too. What I'm thinking here is that we need to turn off the link-on bit in the self ID packets we send out and then generate a bus reset before we suspend. It shouldn't be necessary to change upper level drivers, the SBP-2 driver should just remaind logged in to the storage device. When resuming, we re-enable the link-on bit and do a bus reset again, and should be back in operation.
Kristian
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |